Fix mysql return bug #4450
Merged
Fix mysql return bug #4450
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2020 20:58
Contributor
|
Hi @gengjun-git , you can write "Fix #4449", so that the related issue will be closed automatically when this PR is merged. |
morningman
reviewed
Aug 25, 2020
| if (!isOutfileQuery) { | ||
| sendFields(queryStmt.getColLabels(), queryStmt.getResultExprs()); | ||
| } | ||
| boolean isSendFields = false; |
Contributor
There was a problem hiding this comment.
So the reason is that the fields has been sent but no data is sent following?
Contributor
Author
There was a problem hiding this comment.
Yes, fields has been sent, but query may fail because of timeout. In this case, client will get a fields packet, and error packet, but some language mysql driver cannot recognize the error, and returns a success and no rows result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4449
Send fields after first row arrived so that error packet can be send to client when exception thrown from coord.getNext(). Golang and Python can not identify error if fields packet arrived before error packet.